Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Links in event descriptions don't work #871

Closed
ralphm opened this issue Jul 14, 2023 · 4 comments
Closed

[Bug]: Links in event descriptions don't work #871

ralphm opened this issue Jul 14, 2023 · 4 comments
Assignees
Labels

Comments

@ralphm
Copy link
Member

ralphm commented Jul 14, 2023

Bug description

Each event in the events tab has a description in the table, which some identifiers highlighted and hot-linked to have a quick path to other pages describing the corresponding entity. This includes specific alerts, charts, and nodes, linked by name. For alerts all links now point to https://app.netdata.cloud/spaces/{space}/rooms/{room}/alerts/undefined, and the others link to https://app.netdata.cloud/spaces/{space}/rooms/{room}/events.

Expected behavior

Each link should be to the respective locations for nodes (node view), charts (chart in the overview tab), alerts (probably the alert detail page for that specific transition, by ID).

Steps to reproduce

  1. Open the event tab
  2. Hover over the bolded parts of an event's description.
  3. Observe incorrect URLs.

Screenshots

image

Error Logs

No response

Desktop

OS: Ubuntu 23.04
Browser: Firefox
Browser Version: 116.0b5

Additional context

No response

@ralphm ralphm added bug Something isn't working cloud-frontend needs triage labels Jul 14, 2023
@ralphm
Copy link
Member Author

ralphm commented Jul 17, 2023

Having rechecked this, the undefined issue seems gone, so the hot-linked alert names now do work. The others still point to .../events.

@hugovalente-pm
Copy link
Contributor

was checking this on my local agent and they seem to be working now, I mean besides the undefined that you mentioned that it was fixed already

@hugovalente-pm
Copy link
Contributor

was looking to the links and found an issue on this one
image

if I click on the alert name I get the alert landing page
image

but if I click the Alert instance I'm just directed to the single node page not the chart with the context (and the chart instance) for the alert

@novykh
Copy link
Contributor

novykh commented Aug 17, 2023

Fixed.

@novykh novykh closed this as completed Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants