fix: Browser (UMD) build now bundles corejs (#106)

Netflix · Sep 7, 2018 · ec62fc0 · ec62fc0
1 parent 47d673e
commit ec62fc0
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/build-scripts/rollup.browser.config.js b/build-scripts/rollup.browser.config.js
@@ -18,12 +18,12 @@ export default function createBrowserConfig(options = {}, targets) {
       plugins: [
         alias(lerna()),
         json(),
-        resolve({ browser: true }),
+        resolve({ browser: true, preferBuiltins: true }),
         commonjs(),
         babel({
           babelrc: false,
           runtimeHelpers: true,
-          exclude: '../../../node_modules/**',
+          exclude: ['../../../node_modules/**'],
           presets: [
             [
               '@babel/preset-env',
@@ -37,7 +37,7 @@ export default function createBrowserConfig(options = {}, targets) {
           ],
           plugins: [
             '@babel/plugin-external-helpers',
-            '@babel/plugin-transform-runtime',
+            ['@babel/plugin-transform-runtime', { corejs: 2 }],
             ['@babel/plugin-proposal-object-rest-spread', { useBuiltIns: true }]
           ]
         }),

diff --git a/build-scripts/rollup.node.config.js b/build-scripts/rollup.node.config.js
@@ -16,19 +16,19 @@ export default function createNodeConfig(options = {}) {
       external,
       plugins: [
         json(),
-        resolve(),
+        resolve({ preferBuiltins: true }),
         commonjs(),
         babel({
           babelrc: false,
           runtimeHelpers: true,
-          exclude: '../../../node_modules/**',
+          exclude: ['../../../node_modules/**'],
           presets: [
             [
               '@babel/preset-env',
               {
                 modules: false,
                 targets: {
-                  node: 6
+                  node: '6.0.0'
                 }
               }
             ]

diff --git a/package.json b/package.json
@@ -45,6 +45,7 @@
     "@babel/plugin-transform-runtime": "^7.0.0",
     "@babel/preset-env": "^7.0.0",
     "@babel/runtime": "^7.0.0",
+    "@babel/runtime-corejs2": "^7.0.0",
     "@commitlint/cli": "^7.0.0",
     "@commitlint/config-conventional": "^7.0.1",
     "@commitlint/config-lerna-scopes": "^7.0.0",
@@ -80,8 +81,5 @@
     "rollup-plugin-terser": "^2.0.2",
     "tap-merge": "^0.3.1",
     "testem": "^2.10.0"
-  },
-  "dependencies": {
-    "@babel/runtime-corejs2": "^7.0.0"
   }
 }