fix(adapter-node-http): Improve binary response body handling #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offirgolan
commented
Apr 29, 2020
|
|
||
| server.get(url).passthrough(true); |
There was a problem hiding this comment.
We weren't able to catch this issue since we were doing a passthrough which still went through the adapter.
offirgolan
commented
Apr 29, 2020
| @@ -37,6 +37,10 @@ export default class Response { | |||
|
|
|||
| if (response.body && typeof response.body === 'string') { | |||
| this.content.text = response.body; | |||
|
|
|||
| if (response.isBinary) { | |||
| this.content._isBinary = true; | |||
There was a problem hiding this comment.
_isBinary is only going to the written to the har content if the content is binary. I didnt think it was necessary to always include it. @jasonmit thoughts?
There was a problem hiding this comment.
seems fair but some what on topic - does this constitute a breaking change?
There was a problem hiding this comment.
No, this is backwards compatible but does require to re-record to resolve the issue.
jasonmit
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The core issue was in
getChunksFromBodywhere we pass it the recorded body and response headers. Since the body is a string, it can't really know if the original buffer was binary or not. To get around that, we now store whether the response content is binary or not in the HAR file and expose it via the response class.Motivation and Context
Resolves #327.
Types of Changes
Checklist