Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add json property to Request class #7

Closed
Turbo87 opened this issue Jun 10, 2018 · 1 comment
Closed

Add json property to Request class #7

Turbo87 opened this issue Jun 10, 2018 · 1 comment
Labels
enhancement ✨ New feature or request

Comments

@Turbo87
Copy link

Turbo87 commented Jun 10, 2018

It would be great to have a json convenience property on the Request class which would delegate to JSON.parse(this.body) :)
offirgolan added a commit that referenced this issue Jun 11, 2018
@offirgolan
feat(core): Add json property to Request
bb8e1cb 
Resolves #7.
@offirgolan offirgolan mentioned this issue Jun 11, 2018
Merged
@offirgolan
Copy link
Collaborator

Reopening this issue because I've reverted the PR. I need to think about this a little more and find a solution that will work both for the request and response.

@offirgolan offirgolan reopened this Jun 13, 2018
@offirgolan offirgolan added the enhancement ✨ New feature or request label Jun 13, 2018
@offirgolan offirgolan mentioned this issue Jul 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ✨ New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Turbo87 @offirgolan