Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add NeDropdownFilter component #66

Merged
merged 6 commits into from
Aug 9, 2024
Merged

Conversation

andre8244
Copy link
Collaborator

Add NeDropdownFilter component.

With checkbox options:
image

With radio options:
image

With checkbox options (dark theme):
image

With radio options (dark theme):
image

@andre8244 andre8244 force-pushed the add-nefilter-component branch from aebe5e9 to 39eb301 Compare August 8, 2024 09:55
@andre8244 andre8244 requested a review from Tbaile August 8, 2024 09:55
@andre8244 andre8244 marked this pull request as ready for review August 8, 2024 09:55
Copy link
Collaborator

@Tbaile Tbaile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even with this, changes, it appears that there are a few violations in HTML standard (I.E. divs inside label elements), will look into how to raise these warnings with eslint

src/components/NeDropdownFilter.vue Outdated Show resolved Hide resolved
src/components/NeDropdownFilter.vue Show resolved Hide resolved
src/components/NeDropdownFilter.vue Outdated Show resolved Hide resolved
src/components/NeDropdownFilter.vue Outdated Show resolved Hide resolved
src/components/NeDropdownFilter.vue Outdated Show resolved Hide resolved
@andre8244
Copy link
Collaborator Author

Even with this, changes, it appears that there are a few violations in HTML standard (I.E. divs inside label elements), will look into how to raise these warnings with eslint

Good catch

@andre8244 andre8244 force-pushed the add-nefilter-component branch from f09b13b to a1c30dc Compare August 9, 2024 13:48
@andre8244 andre8244 requested a review from Tbaile August 9, 2024 14:15
src/components/NeDropdownFilter.vue Outdated Show resolved Hide resolved
src/components/NeDropdownFilter.vue Outdated Show resolved Hide resolved
@andre8244 andre8244 requested a review from Tbaile August 9, 2024 14:45
@Tbaile Tbaile merged commit b3b83dc into main Aug 9, 2024
@Tbaile Tbaile deleted the add-nefilter-component branch August 9, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants