Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add invalidMessage prop to all input components #68

Merged
merged 5 commits into from
Aug 9, 2024
Merged

fix: add invalidMessage prop to all input components #68

merged 5 commits into from
Aug 9, 2024

Conversation

andre8244
Copy link
Collaborator

@andre8244 andre8244 commented Aug 8, 2024 •
edited
Loading

Add invalidMessage prop to:

  • NeCheckbox
  • NeRadioSelection
  • NeToggle

Other changes:

  • Add docs page to all components (except NeModal and NeSideDrawer)
  • NeButton: fix font-weight of button label
  • NeRadioSelection:
    • Support label slot
    • Make label prop optional
  • NeFileInput: make accept prop optional

@andre8244 andre8244 marked this pull request as draft August 8, 2024 13:14
@andre8244 andre8244 changed the title fix: minor enhancements to NeButton an NeRadioSelection fix: enhancements to NeButton an NeRadioSelection Aug 8, 2024
@andre8244 andre8244 marked this pull request as ready for review August 8, 2024 14:19
@andre8244 andre8244 requested a review from Tbaile August 8, 2024 14:19
@andre8244 andre8244 changed the title fix: enhancements to NeButton an NeRadioSelection fix: add invalidMessage prop to all input components Aug 8, 2024
Tbaile
Tbaile approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@Tbaile Tbaile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash merge with the title of one of the changes (and the reference of the PR) the other changes can safely be added in the commit description as documented here. (without the PiperOrigin-RevId and source Sheningans, of course)

@andre8244 andre8244 merged commit b33b21f into main Aug 9, 2024
@Tbaile Tbaile deleted the fix-nebutton-font-weight branch August 9, 2024 09:17
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tbaile Tbaile Tbaile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andre8244 @Tbaile