Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add options filtering to NeDropdownFilter #78

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

andre8244
Copy link
Collaborator

@andre8244 andre8244 commented Nov 4, 2024

Changes to NeDropdownFilter:

  • Provide an optional text input for filtering options, allowing the user to choose whether to display it when there are many choices
  • Introduce the maxOptionsShown prop to set the maximum number of options displayed (25 by default). If more options are available, the user is informed and can use the text input to filter and display matching options
  • Automatically display the text input for filtering options when there are more than maxOptionsShown choices available
  • Add the noOptionsLabel prop, displayed when no options are available or when the user's filter query doesn't match any options

@andre8244 andre8244 force-pushed the dropdownfilter-filter-options branch 2 times, most recently from d177d14 to 2a64dc9 Compare November 4, 2024 15:35
@andre8244 andre8244 marked this pull request as ready for review November 4, 2024 15:38
@andre8244 andre8244 requested a review from Tbaile November 4, 2024 15:38
@andre8244 andre8244 force-pushed the dropdownfilter-filter-options branch from 2a64dc9 to d9a3c8d Compare November 6, 2024 13:48
@andre8244 andre8244 merged commit bf3f4b2 into main Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants