Skip to content

Conversation

@andre8244
Copy link
Collaborator

@andre8244 andre8244 commented Aug 29, 2025

  • Add NeBadgeV2 component. Compared to the V1 component:
    • Props have been refactored and streamlined
    • Uses a slot instead of a text property
    • The root element is now an inline element instead of a block one
    • kind values have been renamed for clarity
    • Minor style fixes
  • Other changes:
    • NeListbox: fix width of options list
    • NeTooltip: fix slot to prevent nesting of button elements
    • NeTable: add hover color to rows
    • NeDropdownfilter: add clearSearchLabel prop
    • NeSideDrawer: add show event (useful for avoiding watch boilerplate on parent component)
    • NeButton: add story for icon-only button

@andre8244 andre8244 self-assigned this Aug 29, 2025
@andre8244 andre8244 requested a review from Copilot August 29, 2025 09:16
@andre8244 andre8244 changed the title feat: add NeBadgeV2 and other enhancements feat: add NeBadgeV2 and other fixes Aug 29, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces the new NeBadgeV2 component as a refactored version of the existing badge component, and includes several other UI enhancements. The main purpose is to provide a more flexible and modern badge implementation while improving various existing components.

  • Add NeBadgeV2 component with streamlined props, slot-based content, and span-based root element
  • Fix UI issues in NeListbox, NeTooltip, and NeTable components
  • Add new props and events to NeDropdownFilter and NeSideDrawer components

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/components/NeBadgeV2.vue New badge component implementation with modern API design
stories/NeBadgeV2.stories.ts Storybook stories showcasing the new badge component features
src/main.ts Export the new NeBadgeV2 component
src/components/NeTooltip.vue Fix slot structure to prevent button nesting
src/components/NeTableRow.vue Add hover styling to table rows
src/components/NeListbox.vue Fix options list width calculation
src/components/NeDropdownFilter.vue Add clearSearchLabel prop
src/components/NeSideDrawer.vue Add show event emission
stories/NeDropdownFilter.stories.ts Update story with new clearSearchLabel prop
stories/NeButton.stories.ts Add icon-only button story
src/components/NeToastNotification.vue Wrap timestamp in span for tooltip trigger

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@andre8244 andre8244 marked this pull request as ready for review August 29, 2025 10:03
@andre8244 andre8244 requested a review from Tbaile August 29, 2025 10:03
@Tbaile Tbaile merged commit 466de89 into main Sep 1, 2025
4 checks passed
@Tbaile Tbaile deleted the icon-only-button branch September 1, 2025 10:01
@Tbaile Tbaile mentioned this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants