-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add NeBadgeV2 and other fixes #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces the new NeBadgeV2 component as a refactored version of the existing badge component, and includes several other UI enhancements. The main purpose is to provide a more flexible and modern badge implementation while improving various existing components.
- Add NeBadgeV2 component with streamlined props, slot-based content, and span-based root element
- Fix UI issues in NeListbox, NeTooltip, and NeTable components
- Add new props and events to NeDropdownFilter and NeSideDrawer components
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/components/NeBadgeV2.vue | New badge component implementation with modern API design |
| stories/NeBadgeV2.stories.ts | Storybook stories showcasing the new badge component features |
| src/main.ts | Export the new NeBadgeV2 component |
| src/components/NeTooltip.vue | Fix slot structure to prevent button nesting |
| src/components/NeTableRow.vue | Add hover styling to table rows |
| src/components/NeListbox.vue | Fix options list width calculation |
| src/components/NeDropdownFilter.vue | Add clearSearchLabel prop |
| src/components/NeSideDrawer.vue | Add show event emission |
| stories/NeDropdownFilter.stories.ts | Update story with new clearSearchLabel prop |
| stories/NeButton.stories.ts | Add icon-only button story |
| src/components/NeToastNotification.vue | Wrap timestamp in span for tooltip trigger |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
b48b637 to
ac6831e
Compare
textpropertykindvalues have been renamed for clarityclearSearchLabelpropshowevent (useful for avoidingwatchboilerplate on parent component)