Skip to content

Commit be1707c

Browse files
authored
Merge pull request #19 from clintharrison/clint/monospace-digit
Use the system font with monospace digits
2 parents cc4c5e9 + f87dcf2 commit be1707c

File tree

5 files changed

+31
-31
lines changed

5 files changed

+31
-31
lines changed

Diff for: UTCMenuClock.xcodeproj/project.pbxproj

+9-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
archiveVersion = 1;
44
classes = {
55
};
6-
objectVersion = 46;
6+
objectVersion = 54;
77
objects = {
88

99
/* Begin PBXBuildFile section */
@@ -218,8 +218,9 @@
218218
A8B1187D1471AE3A008A993B /* Project object */ = {
219219
isa = PBXProject;
220220
attributes = {
221+
BuildIndependentTargetsInParallel = YES;
221222
LastTestingUpgradeCheck = 0730;
222-
LastUpgradeCheck = 1400;
223+
LastUpgradeCheck = 1600;
223224
ORGANIZATIONNAME = "";
224225
TargetAttributes = {
225226
A8B118851471AE3A008A993B = {
@@ -378,6 +379,7 @@
378379
DEAD_CODE_STRIPPING = YES;
379380
ENABLE_STRICT_OBJC_MSGSEND = YES;
380381
ENABLE_TESTABILITY = YES;
382+
ENABLE_USER_SCRIPT_SANDBOXING = YES;
381383
GCC_C_LANGUAGE_STANDARD = gnu99;
382384
GCC_DYNAMIC_NO_PIC = NO;
383385
GCC_ENABLE_OBJC_EXCEPTIONS = YES;
@@ -429,6 +431,7 @@
429431
DEAD_CODE_STRIPPING = YES;
430432
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
431433
ENABLE_STRICT_OBJC_MSGSEND = YES;
434+
ENABLE_USER_SCRIPT_SANDBOXING = YES;
432435
GCC_C_LANGUAGE_STANDARD = gnu99;
433436
GCC_ENABLE_OBJC_EXCEPTIONS = YES;
434437
GCC_NO_COMMON_BLOCKS = YES;
@@ -459,6 +462,7 @@
459462
GCC_PRECOMPILE_PREFIX_HEADER = YES;
460463
GCC_PREFIX_HEADER = "UTCMenuClock/UTCMenuClock-Prefix.pch";
461464
INFOPLIST_FILE = "UTCMenuClock/UTCMenuClock-Info.plist";
465+
MACOSX_DEPLOYMENT_TARGET = 11.0;
462466
PRODUCT_BUNDLE_IDENTIFIER = net.retina.UTCMenuClock;
463467
PRODUCT_NAME = "$(TARGET_NAME)";
464468
WRAPPER_EXTENSION = app;
@@ -479,6 +483,7 @@
479483
GCC_PRECOMPILE_PREFIX_HEADER = YES;
480484
GCC_PREFIX_HEADER = "UTCMenuClock/UTCMenuClock-Prefix.pch";
481485
INFOPLIST_FILE = "UTCMenuClock/UTCMenuClock-Info.plist";
486+
MACOSX_DEPLOYMENT_TARGET = 11.0;
482487
PRODUCT_BUNDLE_IDENTIFIER = net.retina.UTCMenuClock;
483488
PRODUCT_NAME = "$(TARGET_NAME)";
484489
WRAPPER_EXTENSION = app;
@@ -496,6 +501,7 @@
496501
GCC_PRECOMPILE_PREFIX_HEADER = YES;
497502
GCC_PREFIX_HEADER = "UTCMenuClock/UTCMenuClock-Prefix.pch";
498503
INFOPLIST_FILE = "UTCMenuClockTests/UTCMenuClockTests-Info.plist";
504+
MACOSX_DEPLOYMENT_TARGET = 11.0;
499505
PRODUCT_BUNDLE_IDENTIFIER = "net.retina.${PRODUCT_NAME:rfc1034identifier}";
500506
PRODUCT_NAME = "$(TARGET_NAME)";
501507
TEST_HOST = "$(BUNDLE_LOADER)";
@@ -514,6 +520,7 @@
514520
GCC_PRECOMPILE_PREFIX_HEADER = YES;
515521
GCC_PREFIX_HEADER = "UTCMenuClock/UTCMenuClock-Prefix.pch";
516522
INFOPLIST_FILE = "UTCMenuClockTests/UTCMenuClockTests-Info.plist";
523+
MACOSX_DEPLOYMENT_TARGET = 11.0;
517524
PRODUCT_BUNDLE_IDENTIFIER = "net.retina.${PRODUCT_NAME:rfc1034identifier}";
518525
PRODUCT_NAME = "$(TARGET_NAME)";
519526
TEST_HOST = "$(BUNDLE_LOADER)";

Diff for: UTCMenuClock.xcodeproj/xcshareddata/xcschemes/UTCMenuClock - Release.xcscheme

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "1400"
3+
LastUpgradeVersion = "1600"
44
version = "1.3">
55
<BuildAction
66
parallelizeBuildables = "YES"

Diff for: UTCMenuClock.xcodeproj/xcshareddata/xcschemes/UTCMenuClock.xcscheme

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "1400"
3+
LastUpgradeVersion = "1600"
44
version = "1.3">
55
<BuildAction
66
parallelizeBuildables = "YES"

Diff for: UTCMenuClock/UTCMenuClock-Info.plist

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
<key>LSApplicationCategoryType</key>
2424
<string>public.app-category.utilities</string>
2525
<key>LSMinimumSystemVersion</key>
26-
<string>10.9</string>
26+
<string>11.0</string>
2727
<key>LSUIElement</key>
2828
<true/>
2929
<key>NSHumanReadableCopyright</key>

Diff for: UTCMenuClock/UTCMenuClockAppDelegate.m

+19-26
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,11 @@ - (void) toggleLaunch:(id)sender {
6363
NSInteger state = [sender state];
6464
LaunchAtLoginController *launchController = [[LaunchAtLoginController alloc] init];
6565

66-
if (state == NSOffState) {
67-
[sender setState:NSOnState];
66+
if (state == NSControlStateValueOff) {
67+
[sender setState:NSControlStateValueOn];
6868
[launchController setLaunchAtLogin:YES];
6969
} else {
70-
[sender setState:NSOffState];
70+
[sender setState:NSControlStateValueOff];
7171
[launchController setLaunchAtLogin:NO];
7272
}
7373

@@ -94,11 +94,11 @@ - (void) togglePreference:(id)sender {
9494
NSString *preference = [sender representedObject];
9595
NSUserDefaults *standardUserDefaults = [NSUserDefaults standardUserDefaults];
9696

97-
if (state == NSOffState) {
98-
[sender setState:NSOnState];
97+
if (state == NSControlStateValueOff) {
98+
[sender setState:NSControlStateValueOn];
9999
[standardUserDefaults setBool:TRUE forKey:preference];
100100
} else {
101-
[sender setState:NSOffState];
101+
[sender setState:NSControlStateValueOff];
102102
[standardUserDefaults setBool:FALSE forKey:preference];
103103
}
104104

@@ -113,7 +113,7 @@ - (void) toggleISOPreference:(id)sender {
113113

114114
[self togglePreference:sender];
115115

116-
if (state == NSOffState) {
116+
if (state == NSControlStateValueOff) {
117117
// disable all of the menu items which are not related to ISO state
118118
[show24Item setEnabled:FALSE];
119119
[showDateItem setEnabled:FALSE];
@@ -258,14 +258,12 @@ - (NSString *) makeDateString {
258258
*/
259259
- (void) doDateUpdate {
260260
NSString *dateString = [self makeDateString];
261-
[ourStatus setTitle:dateString];
262-
261+
ourStatus.button.title = dateString;
263262
}
264263

265264
// Unused for now... need to finish.
266265
- (IBAction)showFontMenu:(id)sender {
267266
NSFontManager *fontManager = [NSFontManager sharedFontManager];
268-
[fontManager setDelegate:self];
269267

270268
NSFontPanel *fontPanel = [fontManager fontPanel:YES];
271269
[fontPanel makeKeyAndOrderFront:sender];
@@ -316,17 +314,12 @@ - (void)awakeFromNib
316314
NSStatusItem *theItem;
317315
theItem = [bar statusItemWithLength:NSVariableStatusItemLength];
318316
[theItem retain];
317+
// while some day we may want more customizable font selection, for now
318+
// set the system font to use fixed-width digits
319+
theItem.button.font = [NSFont monospacedDigitSystemFontOfSize:NSFont.systemFontSize weight:NSFontWeightRegular];
319320
// retain a reference to the item so we don't have to find it again
320321
ourStatus = theItem;
321322

322-
//Set Image
323-
//[theItem setImage:(NSImage *)menuicon];
324-
[theItem setTitle:@""];
325-
326-
//Make it turn blue when you click on it
327-
[theItem setHighlightMode:YES];
328-
[theItem setEnabled: YES];
329-
330323
// build the menu
331324
NSMenuItem *mainItem = [[NSMenuItem alloc] init];
332325
dateMenuItem = mainItem;
@@ -440,14 +433,14 @@ - (void)awakeFromNib
440433
BOOL showISOInstead = [self fetchBooleanPreference:showISO8601PreferenceKey];
441434

442435
// set the menu states based on the preferences
443-
[show24Item setState:show24HrTime ? NSOnState : NSOffState];
444-
[showDateItem setState:showDate ? NSOnState : NSOffState];
445-
[showSecondsItem setState:showSeconds ? NSOnState : NSOffState];
446-
[showJulianItem setState:showJulian ? NSOnState : NSOffState];
447-
[showTimeZoneItem setState:showTimeZone ? NSOnState : NSOffState];
436+
[show24Item setState:show24HrTime ? NSControlStateValueOn : NSControlStateValueOff];
437+
[showDateItem setState:showDate ? NSControlStateValueOn : NSControlStateValueOff];
438+
[showSecondsItem setState:showSeconds ? NSControlStateValueOn : NSControlStateValueOff];
439+
[showJulianItem setState:showJulian ? NSControlStateValueOn : NSControlStateValueOff];
440+
[showTimeZoneItem setState:showTimeZone ? NSControlStateValueOn : NSControlStateValueOff];
448441

449442
if (showISOInstead) {
450-
[showISO8601Item setState:NSOnState];
443+
[showISO8601Item setState:NSControlStateValueOn];
451444

452445
// disable all of the menu items which are not related to ISO state
453446
[show24Item setEnabled:FALSE];
@@ -457,7 +450,7 @@ - (void)awakeFromNib
457450
[showTimeZoneItem setEnabled:FALSE];
458451

459452
} else {
460-
[showISO8601Item setState:NSOffState];
453+
[showISO8601Item setState:NSControlStateValueOff];
461454

462455
// enable all of the menu items which are not related to ISO state
463456
[show24Item setEnabled:TRUE];
@@ -472,7 +465,7 @@ - (void)awakeFromNib
472465
BOOL launch = [launchController launchAtLogin];
473466
[launchController release];
474467

475-
[launchItem setState:launch ? NSOnState : NSOffState];
468+
[launchItem setState:launch ? NSControlStateValueOn : NSControlStateValueOff];
476469

477470
[mainMenu addItem:launchItem];
478471
[mainMenu addItem:show24Item];

0 commit comments

Comments
 (0)