Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error checking in install script #56

Open
AdamBromiley opened this issue Jan 25, 2021 · 0 comments
Open

Error checking in install script #56

AdamBromiley opened this issue Jan 25, 2021 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@AdamBromiley
Copy link
Collaborator

Describe the bug
Half of the commands do not error check, so the install script will continue on error and appear as though the installation succeeded. It's a pretty important issue because this is the third time I've seen someone confused about why their install doesn't work/exist.

Expected behavior
An error message (which should be outputted by the failed command) and immediate exit with sufficient clean-up.

@AdamBromiley AdamBromiley added the bug Something isn't working label Jan 25, 2021
@TechSupportJosh TechSupportJosh added the good first issue Good for newcomers label Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants