-
Notifications
You must be signed in to change notification settings - Fork 12
feat: adds support for detecting NX monorepos #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✅ Deploy Preview for plugin-angular-universal-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks!
Before merging - please let me know if you want to make additional changes (I don't see anything missing at this point) or if it's good to be merged from your perspective
Nope, everything looks good from my end too! |
…r their package path
Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
This was released in 2.3.0 - https://github.com/netlify/angular-runtime/releases/tag/v2.3.0 and I also updated runtime auto-installation rules to use it automatically |
Adds support for detecting NX monorepo structures, allows angular SSR detection to overwrite the generated server.ts and deploy appropriate edge functions for them.
It's not fully clean as it currently requires the
ANGULAR_PROJECT
environment variable to pick up the correctproject.json
. This could have much better DX ifpackagePath
was exposed to the runtime, which as far as I could tell it is not passed through. When creating projects in a user's account it already automatically detects NX and asks for the project to prefill this value, so should be available.Resolves #156