Skip to content

fix: add support for non-bundler module resolution (tsconfig) #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Mar 21, 2025

We rely on export map actually being used with helper functions exported from this package, but this only works with bundler module resolution ( https://www.typescriptlang.org/docs/handbook/modules/theory.html#module-resolution )

So this:

  • adds top level module for those helpers (that re-export from actual implementation)
  • adjust code to use extensions which is more standardized and more likely to work regardless of settings (while keeping previously existing entries in export map, to not break setups for people using extension-less imports)
  • adds initially failing test with non-bundler module resolution that should prove the fix is sufficient

Fixes #269
Fixes https://linear.app/netlify/issue/FRB-1661/netlifyangular-runtime-is-not-exposing-the-api-it-says-in-the

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Mar 21, 2025
Copy link

netlify bot commented Mar 21, 2025

Deploy Preview for plugin-angular-universal-demo ready!

Name Link
🔨 Latest commit 72ac19e
🔍 Latest deploy log https://app.netlify.com/sites/plugin-angular-universal-demo/deploys/67dd8f9f2099e90008e5c3eb
😎 Deploy Preview https://deploy-preview-279--plugin-angular-universal-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pieh pieh force-pushed the michalpiechowiak/frb-1661-netlifyangular-runtime-is-not-exposing-the-api-it-says-in branch from 671d783 to f5891d5 Compare March 21, 2025 08:31
@pieh pieh marked this pull request as ready for review March 21, 2025 10:07
@pieh pieh requested a review from a team as a code owner March 21, 2025 10:07
@pieh pieh changed the title fix: add support non-bundler module resolution (tsconfig) fix: add support for non-bundler module resolution (tsconfig) Mar 21, 2025
@pieh pieh enabled auto-merge (squash) March 21, 2025 16:11
@pieh pieh merged commit ae24696 into main Mar 21, 2025
17 checks passed
@pieh pieh deleted the michalpiechowiak/frb-1661-netlifyangular-runtime-is-not-exposing-the-api-it-says-in branch March 21, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@netlify/angular-runtime is not exposing the api it says in the documentation
2 participants