fix: adapt publish directory based on builder #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plugin-angular-universal-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JGAntunes
reviewed
Dec 11, 2023
|
done! |
lukasholzer
reviewed
Feb 2, 2024
| @@ -9,7 +9,8 @@ const fixOutputDir = async function ({ failBuild, failPlugin, siteRoot, PUBLISH_ | |||
|
|
|||
| const { outputPath } = project.architect.build.options | |||
|
|
|||
| const correctPublishDir = join(outputPath, 'browser') | |||
| const isApplicationBuilder = project.architect.build.builder.endsWith(':application') | |||
There was a problem hiding this comment.
have you checked this with nx workspaces as well? 🤔
lukasholzer
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Angular world, a
builderis something like a bundling strategy, and they decide where to output static assets. Newly created Angular applications use theapplicationbuilder, which emits static assets intodist/<project-name>/browser. Old applications that updated to NG17 can still use other builders, like thebrowserbuilder. Surprise: They output intodist/<project-name>! This PR adds two tests for application builder and browser builder, and adapts the publish directory we're expecting based on that.