fix: move build-info to mono repository of netlify build #4584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
lukasholzer
force-pushed
the
feat/move-build-info-to-monorepo
branch
from
57b849d to
69fbf79
Compare
7 tasks
lukasholzer
force-pushed
the
feat/move-build-info-to-monorepo
branch
from
69fbf79 to
0f6951f
Compare
jobala
suggested changes
Oct 10, 2022
packages/build-info/package.json
Outdated
| "test": "ava", | ||
| "test:ci": "c8 -r lcovonly -r text -r json ava" | ||
| }, | ||
| "ava": { |
There was a problem hiding this comment.
In this case we don't want to extend ava's base config as all the properties are different and it's a different project basically. So testing was set up differently. (No splitting up needed here etc.)
There was a problem hiding this comment.
Ah I see. We should at least use ava.config.js instead of having the configuration in package.json that way this package will be structurally consistent with the other packages.
jobala
approved these changes
Oct 10, 2022
Merged
danez
reviewed
Oct 10, 2022
| @@ -0,0 +1,112 @@ | |||
| [](https://github.com/netlify/build-info/actions) | |||
|
|
||
| ## Contributors | ||
|
|
||
| Please see [CONTRIBUTING.md](./CONTRIBUTING.md) for instructions on how to set up and work on this repository. Thanks |
|
oh my review was too late :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
This is one part of #4545
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)