fix: don't overwrite plugin origin if it exists #5793
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Part of https://linear.app/netlify/issue/FRP-1218/plugin-netlifyplugin-nextjs-must-not-be-specified-twice-in-the-app
netlify/cli#6781 is related to this and does add
default
origin to plugins added to default config by framework detection and this change ensures thatorigin
is not being overwritten and instead normalization prefers existingorigin
over argument provided toaddConfigPluginOrigin
which later allow validation to pass as it no longer has 2 plugins (one from default config provided by framework detection and one from bitballoon when runtime is set) from same origin (as those are 2 different origins really, not single one)For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)