Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug(docs): we're missing netlify logout command from the docs and help #1123

Open
erezrokah opened this issue Aug 20, 2020 · 2 comments
Open
Labels
area: commands: login good first issue type: bug code to address defects in shipped code

Comments

@erezrokah
Copy link
Contributor

  1. Goto https://cli.netlify.com/, see that the logout command is missing
  2. Run netlify help - see that it doesn't print the logout command in the console.

Related to #660 (comment).

Not sure why, but hiding the command seems intentional:

LogoutCommand.hidden = true

@erezrokah erezrokah added type: bug code to address defects in shipped code area: commands: login labels Aug 20, 2020
@erezrokah erezrokah self-assigned this Aug 20, 2020
@erezrokah erezrokah removed their assignment Sep 23, 2020
@Xenonym
Copy link
Contributor

Xenonym commented Oct 2, 2020

According to #141, the logout command was hidden two years ago (emphasis mine):

Hide logout command

Since we started going down the multi-user path, logout doesn’t actually log you out. We should prioritize getting user switching in soon after the launch.

@erezrokah
Copy link
Contributor Author

Since a user can revoke the CLI access token in the UI, we should look into doing the same thing when a user logs out:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: commands: login good first issue type: bug code to address defects in shipped code
Projects
None yet
Development

No branches or pull requests

3 participants