-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
does not work with node 10 #40
Comments
This cli is no longer supported, please switch to https://github.com/netlify/netlifyctl |
@bcomnes: you should mark the npm package as deprecated then... |
Agreed, I'll look into to doing that. It would be nice to find a way to ship the go bin as an npm package so people can switch over to that without integrating a peer dep. |
@bcomnes As a first step though, I agree that it would be super helpful to mark the npm package as deprecated and provide a link out to the new cli in the deprecation message. |
Now this doesn't work in Node 10, you really had ought to update your docs to use |
In addition to marking the npm package as deprecated a bigger notice in the README would be helpful as well. I had to read it several times before I noticed it included a deprecation notice. |
SO proud to say that one of my Junior dev's found her own solution to this. Just run these commands in sequence in the your project's directory: note: it's npm cache that's causing the biggest issues in our situation. Hope this helps |
Recent development, we are revisiting plans around the Node netlify api lib and CLI. Will follow up with more details asap, but we are thinking of resurrecting a JS/Node cli. |
Thanks so much guy, you helpout me !!! # @singuista |
Any updates on this? Should I uninstall the old cli and install this new cli going forward? |
Apologies for the delayed response. We are working on/exploring a revamped node-cli with a new architecture that will be flexible enough for some really exciting developments we have coming down the pipe. That won't be ready for a bit, so in the meantime, I'll go ahead and do a little bit of cleanup regarding the lock files mentioned by @singuista and cut a patch release to see if that fixes some of the showstoppers on this codebase. Also github.com/netlify/netlifyctl is a viable and working option, however I do sympathize that go tooling doesn't have the cleanest integration path that npm published tools have with most web projects that are already using npm/yarn. Hold tight! If you have a moment as well, I would love to hear some feedback what you want most out of the cli experience. Trying to avoid the web UI and use the console only? Custom deploys from private CI environments? Advanced automation integrations? |
Ok 🎉 Tested on node 10, can confirm its working. |
@bcomnes so, which cli out of the two is deprecated? |
This one. |
@bcomnes Suggestion: Just make it as simple as the Now CLI or Surge CLI. No need for Just simple command Why waste so much time on architecture when your competitors have already solved the same problem? I prefer both NOW & SURGE CLIs but I ❤️ Netlify & CLI can be a huge boon |
node[13766]: ../src/node_contextify.cc:631:static void node::contextify::ContextifyScript::New(const FunctionCallbackInfo<v8::Value> &): Assertion `args[1]->IsString()' failed. 1: node::Abort() [/usr/local/bin/node] 2: node::Assert(char const* const (*) [4]) [/usr/local/bin/node] 3: node::contextify::ContextifyScript::New(v8::FunctionCallbackInfo<v8::Value> const&) [/usr/local/bin/node] 4: v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo*) [/usr/local/bin/node] 5: v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<true>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments) [/usr/local/bin/node] 6: v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) [/usr/local/bin/node]
Due to reliance on
natives
package. See nodejs bug reports nodejs/node#20325, nodejs/node#20281, nodejs/node#20285The text was updated successfully, but these errors were encountered: