Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make site suggestion flow consistent #4185

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

tinfoil-knight
Copy link
Contributor

@tinfoil-knight tinfoil-knight commented Feb 5, 2022

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes #1772

Earlier while creating a new site, the name suggested by the CLI and the name with which the site was actually created were different. This happened because the name suggested by the CLI wasn't considered and an empty name field was passed to the Netlify API which assigned a random site name on its own.

This PR fixes that behavior. Names suggested by the CLI will be set consistently when creating the site.

Test Run Post Fix with init

Screenshot 2022-02-05 at 5 32 11 PM


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

@tinfoil-knight tinfoil-knight marked this pull request as draft February 5, 2022 18:59
@tinfoil-knight tinfoil-knight changed the title fix: make site suggestion flow consistent [WIP] fix: make site suggestion flow consistent Feb 5, 2022
@tinfoil-knight tinfoil-knight marked this pull request as ready for review February 5, 2022 19:11
@tinfoil-knight tinfoil-knight changed the title [WIP] fix: make site suggestion flow consistent fix: make site suggestion flow consistent Feb 5, 2022
@erezrokah erezrokah added the type: bug code to address defects in shipped code label Feb 7, 2022
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tinfoil-knight 🚀

@erezrokah erezrokah merged commit fbd9156 into netlify:main Feb 8, 2022
@tinfoil-knight tinfoil-knight deleted the fix/1772-site-name branch February 8, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve site name suggestion flow
2 participants