fix: make site suggestion flow consistent #4185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes #1772
Earlier while creating a new site, the name suggested by the CLI and the name with which the site was actually created were different. This happened because the name suggested by the CLI wasn't considered and an empty name field was passed to the Netlify API which assigned a random site name on its own.
This PR fixes that behavior. Names suggested by the CLI will be set consistently when creating the site.
Test Run Post Fix with
init
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.