Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: additional graph commands, extra graph codegen tests, and type definitions #4186

Merged
merged 30 commits into from
Feb 8, 2022

Conversation

sgrove
Copy link
Contributor

@sgrove sgrove commented Feb 6, 2022

Summary

Continuing to polish the graph experience, and as things start to solidify (we're changing the generated code style much less frequently now) adding in some snapshot tests to make maintenance easier.

(Probable) Bug fix:

Incorporates @ehmicky's suggestion to handle filenames with spaces in them here

Codebase improvements:

Fixes some codegen failures, and adds a test matrix to keep track of the outputs of various flag combinations as well
Adds some type definitions (I didn't know about // @ts-check, quite helpful!)

To make the Graph DX completely usable from the CLI (no web GUI):

Adds a graph:library command to generate the function library based on the operation file
Adds a graph:handler command to generate a handler via the operation name locally (makes the UI optional for the normal flow)
Adds a graph:operations command to list the operations available in the local library


For us to review and ship your PR efficiently, please perform the following steps:

  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

@sgrove sgrove added the type: bug code to address defects in shipped code label Feb 6, 2022
@sgrove sgrove changed the title Graph codegen extra tests feat: graph:handler command, graph-codegen extra tests, and type definitions Feb 6, 2022
@sgrove sgrove added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Feb 7, 2022
@sgrove sgrove marked this pull request as ready for review February 7, 2022 06:14
@sgrove sgrove requested a review from a team as a code owner February 7, 2022 06:14
@sgrove sgrove changed the title feat: graph:handler command, graph-codegen extra tests, and type definitions feat: graph:handler command, extra graph-codegen tests, and type definitions Feb 7, 2022
@sgrove sgrove changed the title feat: graph:handler command, extra graph-codegen tests, and type definitions feat: additional graph commands, extra graph codegen tests, and type definitions Feb 7, 2022
@sgrove sgrove requested a review from anmonteiro February 7, 2022 07:44
@erezrokah erezrokah added the automerge Add to Kodiak auto merge queue label Feb 7, 2022
@sgrove sgrove requested review from anmonteiro and removed request for anmonteiro February 7, 2022 18:27
anmonteiro
anmonteiro previously approved these changes Feb 7, 2022
@sgrove sgrove enabled auto-merge (squash) February 7, 2022 19:17
@sgrove sgrove removed the request for review from a team February 7, 2022 19:17
@sgrove
Copy link
Contributor Author

sgrove commented Feb 8, 2022

Failing tests seem to be related to #3948

@sgrove sgrove merged commit 76b6206 into netlify:main Feb 8, 2022
@erezrokah erezrokah mentioned this pull request Feb 8, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Add to Kodiak auto merge queue type: bug code to address defects in shipped code type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants