-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: additional graph
commands, extra graph codegen tests, and type definitions
#4186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgrove
changed the title
Graph codegen extra tests
feat: Feb 6, 2022
graph:handler
command, graph-codegen extra tests, and type definitions
sgrove
added
the
type: feature
code contributing to the implementation of a feature and/or user facing functionality
label
Feb 7, 2022
sgrove
changed the title
feat:
feat: Feb 7, 2022
graph:handler
command, graph-codegen extra tests, and type definitionsgraph:handler
command, extra graph-codegen tests, and type definitions
sgrove
changed the title
feat:
feat: additional Feb 7, 2022
graph:handler
command, extra graph-codegen tests, and type definitionsgraph
commands, extra graph codegen tests, and type definitions
anmonteiro
previously approved these changes
Feb 7, 2022
Failing tests seem to be related to #3948 |
anmonteiro
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automerge
Add to Kodiak auto merge queue
type: bug
code to address defects in shipped code
type: feature
code contributing to the implementation of a feature and/or user facing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Continuing to polish the graph experience, and as things start to solidify (we're changing the generated code style much less frequently now) adding in some snapshot tests to make maintenance easier.
(Probable) Bug fix:
Incorporates @ehmicky's suggestion to handle filenames with spaces in them here
Codebase improvements:
Fixes some codegen failures, and adds a test matrix to keep track of the outputs of various flag combinations as well
Adds some type definitions (I didn't know about
// @ts-check
, quite helpful!)To make the Graph DX completely usable from the CLI (no web GUI):
Adds a
graph:library
command to generate the function library based on the operation fileAdds a
graph:handler
command to generate a handler via the operation name locally (makes the UI optional for the normal flow)Adds a
graph:operations
command to list the operations available in the local libraryFor us to review and ship your PR efficiently, please perform the following steps: