feat: netlify dev --graph: watch config.toml and reload automatically
#4268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: feature
📊 Benchmark resultsComparing with fa3980d Package size: 442 MB(no change) Legend
|
erezrokah
suggested changes
Feb 14, 2022
There was a problem hiding this comment.
Thanks @anmonteiro, added a comment.
I think it would be better to introduce this functionality only when the graph flag is passed to reduce the risk of this breaking other commands.
ehmicky
reviewed
Feb 14, 2022
| const watchDebounced = async (target, { depth, onAdd = () => {}, onChange = () => {}, onUnlink = () => {} }) => { | ||
| const watcher = chokidar.watch(target, { depth, ignored: /node_modules/, ignoreInitial: true }) | ||
|
|
||
| await pEvent(watcher, 'ready') |
There was a problem hiding this comment.
chokidar can emit error events.
Not a blocker for this PR, but we might consider handling those.
erezrokah
previously approved these changes
Feb 14, 2022
ehmicky
reviewed
Feb 14, 2022
src/commands/base-command.js
Outdated
| watchDebounced(configPath, { | ||
| depth: 1, | ||
| onChange: async () => { | ||
| const { config: newConfig } = await actionCommand.getConfig({ cwd, state, token, ...apiUrlOpts }) |
There was a problem hiding this comment.
Adding/removing/changing a netlify.toml might also modify the buildDir and the configPath returned by actionCommand.getConfig().
In a follow-up PR, we should consider handling this.
There was a problem hiding this comment.
This is very well spotted, and it also looks a little harder than a quickfix. I'm going to open an issue to track it.
ehmicky
previously approved these changes
Feb 14, 2022
ehmicky
previously approved these changes
Feb 14, 2022
sgrove
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes https://github.com/netlify/netlify-graph-project-planning/issues/16
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)