Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(functions): stop providing clientContext to background functions #4395

Merged
merged 4 commits into from
Mar 2, 2022

Conversation

erquhart
Copy link
Contributor

@erquhart erquhart commented Feb 28, 2022

Summary

Fixes #4383

Removes context.clientContext for background functions to match production behavior.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)
Ah, animal pictures go on the PR, that's right. Here, have some more hippos:
image

@erezrokah erezrokah added the type: bug code to address defects in shipped code label Feb 28, 2022
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @erquhart, looks great.

I added a test to capture this use case.

@erezrokah erezrokah added the automerge Add to Kodiak auto merge queue label Mar 2, 2022
@kodiakhq kodiakhq bot merged commit e14feb2 into netlify:main Mar 2, 2022
@erquhart erquhart deleted the drop-background-clientcontext branch March 4, 2022 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Add to Kodiak auto merge queue type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Background functions provide a clientContext and user locally, but not in production
2 participants