-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add HTTPS support for Edge Functions in Netlify Dev #4567
Conversation
📊 Benchmark resultsComparing with 6695113 Package size: 274 MB⬆️ 0.17% increase vs. 6695113
Legend
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICT, this will require every developer cloning this repository to run npm run certs
as part of setting up their development environment. Could we use something like https://www.npmjs.com/package/openssl-nodejs (or execa) to generate the certificates as part of the test run? Or is that too resource-intensive?
@Skn0tt I've added |
Yes, that's good 👍 |
Summary
Fixes an issue where origin requests in Edge Functions will fail when running Netlify Dev with HTTPS enabled.
Builds on top of https://github.com/netlify/edge-functions-bootstrap/pull/30 and netlify/edge-bundler#7 (the tests will fail until both of these are merged and released).
Closes https://github.com/netlify/pillar-runtime/issues/323.