fix: use correct paths when deploying edge functions on Windows #4760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with f8cc372 Package size: 221 MB(no change) Legend
|
eduardoboucas
commented
Jul 1, 2022
| @@ -10,7 +9,7 @@ const distPath = getPathInProject([EDGE_FUNCTIONS_FOLDER]) | |||
|
|
|||
| const deployFileNormalizer = (file) => { | |||
| const isEdgeFunction = file.root === distPath | |||
| const normalizedPath = isEdgeFunction ? path.join(PUBLIC_URL_PATH, file.normalizedPath) : file.normalizedPath | |||
There was a problem hiding this comment.
This effectively a URL, not a filesystem path. So it needs to use the UNIX format regardless of the host platform.
eduardoboucas
commented
Jul 1, 2022
| @@ -113,8 +113,7 @@ if (process.env.NETLIFY_TEST_DISABLE_LIVE !== 'true') { | |||
| }) | |||
| }) | |||
|
|
|||
| // TODO: Re-add when feature flag is no longer needed. | |||
| test.serial.skip('should deploy Edge Functions when directory exists', async (t) => { | |||
| test.serial('should deploy Edge Functions when directory exists', async (t) => { | |||
There was a problem hiding this comment.
This test would've caught this, but we never enabled it after the public beta. 😞
danez
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The paths we supply to the
fileshash needs to be in the unix format.