fix: make git clone work in sites:create-template

[danez]

Summary

git_url from the github api contains the plaintext git:// url which github itself does not support anymore. Instead, use the clone_url form the API which contains the https:// git URL

Currently when running the command this happens:

❯ ../netlify/cli/bin/run sites:create-template nextjs-blog-theme
? Team: Daniel Tschinder's team
Choose a unique site name (e.g. isnt-danez-awesome.netlify.app) or leave it blank for a random name. You can update the site name later.
? Site name (optional): undefined

Site Created

Admin URL: https://app.netlify.com/sites/isnt-danez-awesome
URL:       https://isnt-danez-awesome.netlify.app
Site ID:   429aa7d1-77fb-43ef-b45c-05857d885e46
Repo URL:  https://github.com/danez/isnt-danez-awesome
? Do you want to clone the repository? Yes

 ›   Error: Command failed with exit code 128: git clone git://github.com/danez/isnt-danez-awesome.git isnt-danez-awesome
Cloning into 'isnt-danez-awesome'...
fatal: unable to connect to github.com:
github.com[0: 140.82.121.4]: errno=Operation timed out

Additional

Also switch to use execa instead of git-clone to save one dependency. I checked what git-clone does internally and that is pretty much exactly what I do in this PR. git-clone has some advanced features, like custom path to git binary or checkout different branch after clone, but we are not using any of these.

No test was added, because we mock the whole github API, so even if I would mock execa and assert it was called with the mocked git URL, it won't test if the actual URL will work or not

[github-actions]

📊 Benchmark results

Comparing with 21a5d0c

Package size: 227 MB

⬇️ 0.02% decrease vs. 21a5d0c

^                                                                                                  227 MB 
│  221 MB  221 MB  221 MB  221 MB  221 MB  221 MB  221 MB  221 MB  221 MB  221 MB  221 MB  221 MB   ┌──┐  
│   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    

Legend

• T-30 (21a5d0c): 227 MB
• T-29 (5421407): 227 MB
• T-28 (ce784fe): 227 MB
• T-27 (631f9e5): 221 MB
• T-26 (6541f32): 221 MB
• T-25 (7e5c301): 221 MB
• T-24 (e016c74): 221 MB
• T-23 (48c3aa3): 221 MB
• T-22 (0d9f657): 221 MB
• T-21 (1d0e6ef): 221 MB
• T-20 (756ddd9): 221 MB
• T-19 (ac913f4): 221 MB
• T-18 (8248c35): 221 MB
• T-17 (55d7013): 221 MB
• T-16 (80df246): 221 MB
• T-15 (f8cc372): 221 MB
• T-14 (ea91c62): 221 MB
• T-13 (282add9): 221 MB
• T-12 (e0695f9): 221 MB
• T-11 (7dedadc): 221 MB
• T-10 (63d4520): 221 MB
• T-9 (f341e05): 221 MB
• T-8 (b4d6eef): 221 MB
• T-7 (85db12b): 221 MB
• T-6 (b00ad87): 221 MB
• T-5 (f36f0fc): 221 MB
• T-4 (8c127b8): 221 MB
• T-3 (9b6adad): 221 MB
• T-2 (bbb9638): 221 MB
• T-1 (68c4abf): 221 MB
• T (current commit): 227 MB

[danez]

Maybe @netlify/templates could have a look because I guess this falls in your territory.

[tzmanics]

This worked great!!! Thanks for digging into this!! Much appreciated!

[Skn0tt]

Looks good!