-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: connect to a cloud session #4776
Conversation
📊 Benchmark resultsComparing with 74527f4 Package size: 227 MB(no change)
Legend
|
Should there be a way to write the sessionId out to disk? Asking people to run |
This bit of the code is doing exactly that: https://github.com/netlify/cli/pull/4776/files#diff-9ccd1df2dd366a5ce3a03412d25d3ea094c0ead5496cba18157c70a7670f294eR710 |
Ah, I missed the `state.set`, I was looking for a more explicit `set!` type
of method/name. Thanks!
…On Wed, Jul 6, 2022 at 2:34 PM Antonio Nuno Monteiro < ***@***.***> wrote:
This bit of the code is doing exactly that:
https://github.com/netlify/cli/pull/4776/files#diff-9ccd1df2dd366a5ce3a03412d25d3ea094c0ead5496cba18157c70a7670f294eR710
—
Reply to this email directly, view it on GitHub
<#4776 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAITYDKHXN2776QGUQAQ2TVSX3VZANCNFSM523FFK7Q>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
🎉 Thanks for submitting a pull request! 🎉
Summary
Allow
netlify dev --graph --sessionId=...
to connect to a cloud session.For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)