fix: Update getTemplatesFromGitHub to retrieve more repositories #4789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxcell
changed the title
maxcell
added
the
type: chore
maxcell
changed the title
danez
approved these changes
Jul 11, 2022
danez
added
type: bug
danez
changed the title
|
I can do that! Thank you for the feedback @danez! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4777
When a user uses the CLI for generating a site with a template, we want to make sure only the appropriate repos show up for us. Right now that's all public, non-archived projects. The default limit is 30, so we also doubled the site request for now.
I wasn't quite sure if I should make a separate test for validating that the other repository do not show up but I modified the example at least so it should still pass other tests.
A picture of a cute animal (not mandatory, but encouraged)
