fix: publish shrinkwrap with prod dependencies only #5359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
commented
Jan 11, 2023
| @@ -38,7 +38,7 @@ | |||
| "url": "https://github.com/netlify/cli/issues" | |||
| }, | |||
| "scripts": { | |||
| "prepare": "husky install node_modules/@netlify/eslint-config-node/.husky/", | |||
| "prepare": "is-ci || husky install node_modules/@netlify/eslint-config-node/.husky/", | |||
There was a problem hiding this comment.
We don't need husky in CI, it just slows done publish by running lint and stuff, which at that point should all be good.
danez
commented
Jan 11, 2023
| cache-dependency-path: 'npm-shrinkwrap.json' | ||
| check-latest: true | ||
| node-version: lts/* | ||
| cache: npm |
There was a problem hiding this comment.
All non-test workflows I changed to use the latest lts version instead of the latest version and not do extra requests to check for the latest. The nodejs version here does not really matter, and I think it is good to use the most stable one which is lts.
📊 Benchmark resultsComparing with c133956 Package size: 259 MB⬆️ 0.00% increase vs. c133956 Legend
|
lukasholzer
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5323
It removes the shrinkwrap from the repo and instead uses the normal package-lock.
On publish we create the shrinkwrap, but only for prod dependencies.
Also split up the workflow into 2 jobs so we do not have to repeat the
if: ${{ steps.release.outputs.release_created }}for every single step.