feat!: drop node 14.16 and 14.17 #5602

danez · 2023-03-30T15:15:20Z

🎉 Thanks for submitting a pull request! 🎉

Summary

Drops node 14.16 and 14.17 as discussed

Fixes #5575

For us to review and ship your PR efficiently, please perform the following steps:

Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
Read the contribution guidelines 📖. This ensures your code follows our style guide and
passes our tests.
Update or add tests (if any source code was changed or added) 🧪
Update or add documentation (if features were changed or added) 📝
Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

github-actions · 2023-03-30T15:17:22Z

📊 Benchmark results

Comparing with 9775e40

Package size: 306 MB

⬇️ 0.00% decrease vs. 9775e40

^                                                                                  302 MB  306 MB  306 MB 
│                                                                                   ┌──┐    ┌──┐    ┌──┐  
│                                                                  271 MB  271 MB   |  |    |  |    |▒▒|  
│ ─264 MB──264 MB──264 MB──264 MB──264 MB──264 MB──264 MB──264 MB───┌──┐────┌──┐────┼──┼────┼──┼────|▒▒|──
│   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (71e43e8): 271 MB
T-29 (4a4d2a3): 264 MB
T-28 (93e6f02): 264 MB
T-27 (be1f66d): 264 MB
T-26 (e337907): 271 MB
T-25 (694d005): 271 MB
T-24 (e118555): 271 MB
T-23 (618a41e): 264 MB
T-22 (f437d30): 264 MB
T-21 (1311734): 264 MB
T-20 (6d46850): 264 MB
T-19 (b468d2f): 264 MB
T-18 (e11d53f): 264 MB
T-17 (3bf1eef): 264 MB
T-16 (c9710cf): 264 MB
T-15 (247c717): 271 MB
T-14 (145b9ea): 264 MB
T-13 (06dc967): 264 MB
T-12 (cd6f33d): 264 MB
T-11 (fd4d358): 264 MB
T-10 (ace82dd): 264 MB
T-9 (f82421c): 264 MB
T-8 (0c6278d): 264 MB
T-7 (899c567): 264 MB
T-6 (8126648): 264 MB
T-5 (54ecf6d): 264 MB
T-4 (187d3a8): 271 MB
T-3 (d0cddc9): 271 MB
T-2 (c1cb456): 302 MB
T-1 (9775e40): 306 MB
T (current commit): 306 MB

lukasholzer

🥳 Yay

lukasholzer · 2023-03-31T09:30:39Z

@danez I think you need to fix the required checks to get this through

danez · 2023-03-31T11:14:26Z

tests/integration/510.hugo.test.cjs

-// we need something to run in case the test above is skipped.
-test('dummy test', (t) => {
-  t.true(true)
-})


This test was failing on Node.js 14.18 on windows, after migrating to vitest it works. 🤷 Maybe because I also updated hugo and recreated the lockfile of the fixture.

Also the test was not run on latest node version, although it succeeds on these versions now, so removed the restriction where to run the test

danez · 2023-03-31T11:14:53Z

tests/integration/utils/fixture.mjs

 import { fileURLToPath } from 'url'

-import cpy from 'cpy'
+import { copy } from 'fs-extra'


cpy cannot copy symlinks, so I exchanged it for fs-extra -> copy

whats about fs.cp with recursive option? I think this uses the file system copy under the hood which should copy symlinks as well

Only available as of Node.js 16.7.0

danez · 2023-03-31T11:15:35Z

tests/integration/utils/fixture.mjs

@@ -29,7 +30,7 @@ export const setupFixtureTests = async function (options, factory) {

  beforeAll(async () => {
    if (options.fixture) fixture = await Fixture.create(options.fixture)
-    if (options.devServer) devServer = await startDevServer({ cwd: fixture.directory })
+    if (options.devServer) devServer = await startDevServer({ cwd: fixture.directory, args: ['--offline'] })


when we run the dev server in fixture tests we should never read settings from the API.

good point!

lukasholzer

@danez can we update the postinstall script to not break if being installed on a unsupported engine version?

As the engine is only a warning?

Instead exit the postinstall script with a better error messaging?

danez · 2023-04-11T11:12:16Z

I guess what you want is something like this: #5244

We can try to make the postinstall script Node.js version agnostic, but this is unrelated to this PR.

lukasholzer

LGTM

XhmikosR · 2023-05-16T05:39:08Z

tests/integration/__fixtures__/hugo-site/package.json

@@ -6,6 +6,6 @@
  },
  "license": "MIT",
  "devDependencies": {
-    "hugo-bin": "^0.101.0"
+    "hugo-bin": "^0.101.5"


@danez I think you could also go with https://github.com/fenneclab/hugo-bin/releases/tag/v0.102.0 :)

danez requested a review from lukasholzer March 30, 2023 15:28

danez marked this pull request as ready for review March 30, 2023 15:28

danez requested a review from a team March 30, 2023 15:28

danez requested a review from a team as a code owner March 30, 2023 15:28

danez self-assigned this Mar 31, 2023

lukasholzer previously approved these changes Mar 31, 2023

View reviewed changes

danez dismissed lukasholzer’s stale review via 10f8df1 March 31, 2023 09:57

danez force-pushed the node14 branch 4 times, most recently from 536e693 to 7e7485d Compare March 31, 2023 11:11

danez commented Mar 31, 2023

View reviewed changes

danez requested review from lukasholzer and pieh March 31, 2023 11:36

danez force-pushed the node14 branch from abb5690 to 5660ea4 Compare April 11, 2023 10:10

lukasholzer reviewed Apr 11, 2023

View reviewed changes

lukasholzer previously approved these changes Apr 11, 2023

View reviewed changes

danez added 2 commits April 11, 2023 16:49

feat!: drop node 14.16 and 14.17

c8125d5

chore: update hugo test

71f1ed3

danez dismissed lukasholzer’s stale review via 71f1ed3 April 11, 2023 14:52

danez force-pushed the node14 branch from 5660ea4 to 71f1ed3 Compare April 11, 2023 14:52

danez requested a review from lukasholzer April 11, 2023 14:52

lukasholzer approved these changes Apr 11, 2023

View reviewed changes

danez merged commit 8bcc4c9 into main Apr 11, 2023

danez deleted the node14 branch April 11, 2023 16:09

token-generator-app bot mentioned this pull request Apr 11, 2023

chore(main): release 14.0.0 #5600

Merged

XhmikosR reviewed May 16, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: drop node 14.16 and 14.17 #5602

feat!: drop node 14.16 and 14.17 #5602

danez commented Mar 30, 2023 •

edited

Loading

github-actions bot commented Mar 30, 2023 •

edited

Loading

lukasholzer left a comment

lukasholzer commented Mar 31, 2023

danez Mar 31, 2023 •

edited

Loading

danez Mar 31, 2023

lukasholzer Mar 31, 2023

danez Mar 31, 2023

danez Mar 31, 2023 •

edited

Loading

lukasholzer Mar 31, 2023

lukasholzer left a comment

danez commented Apr 11, 2023

lukasholzer left a comment

XhmikosR May 16, 2023

feat!: drop node 14.16 and 14.17 #5602

feat!: drop node 14.16 and 14.17 #5602

Conversation

danez commented Mar 30, 2023 • edited Loading

Summary

github-actions bot commented Mar 30, 2023 • edited Loading

📊 Benchmark results

Package size: 306 MB

lukasholzer left a comment

Choose a reason for hiding this comment

lukasholzer commented Mar 31, 2023

danez Mar 31, 2023 • edited Loading

Choose a reason for hiding this comment

danez Mar 31, 2023

Choose a reason for hiding this comment

lukasholzer Mar 31, 2023

Choose a reason for hiding this comment

danez Mar 31, 2023

Choose a reason for hiding this comment

danez Mar 31, 2023 • edited Loading

Choose a reason for hiding this comment

lukasholzer Mar 31, 2023

Choose a reason for hiding this comment

lukasholzer left a comment

Choose a reason for hiding this comment

danez commented Apr 11, 2023

lukasholzer left a comment

Choose a reason for hiding this comment

XhmikosR May 16, 2023

Choose a reason for hiding this comment

danez commented Mar 30, 2023 •

edited

Loading

github-actions bot commented Mar 30, 2023 •

edited

Loading

danez Mar 31, 2023 •

edited

Loading

danez Mar 31, 2023 •

edited

Loading