Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add buildData to track serverless functions api version #6059

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

jenae-janzen
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉
Adds observability to track adoption of the new functions api.

Summary

Fixes #<replace_with_issue_number>


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@jenae-janzen jenae-janzen requested a review from Skn0tt October 12, 2023 13:28
@jenae-janzen jenae-janzen requested a review from a team as a code owner October 12, 2023 13:28
@github-actions
Copy link

github-actions bot commented Oct 12, 2023

📊 Benchmark results

Comparing with 8e0d28d

  • Dependency count: 1,369 (no change)
  • Package size: 379 MB ⬇️ 0.00% decrease vs. 8e0d28d

.reduce(
(funcs, curr) => ({
...funcs,
[curr.name]: { display_name: curr.displayName, generator: curr.generator, routes: curr.routes },
[curr.name]: { display_name: curr.displayName, generator: curr.generator, routes: curr.routes, buildData: curr.buildData },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[curr.name]: { display_name: curr.displayName, generator: curr.generator, routes: curr.routes, buildData: curr.buildData },
[curr.name]: { display_name: curr.displayName, generator: curr.generator, routes: curr.routes, build_data: curr.buildData },

I believe it needs to be snake-case:

https://github.com/netlify/bitballoon/blob/217df0749107d907b3dee20f9054cca6700d2a3e/app/controllers/api/v1/deploys_controller.rb#L99

@jenae-janzen jenae-janzen merged commit 3dee20c into main Oct 12, 2023
61 checks passed
@jenae-janzen jenae-janzen deleted the add-serverles-function-api-version branch October 12, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants