fix: functions:serve should serve V2 Functions
#6290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Starting with Draft to see if there's any failing tests. |
Skn0tt
commented
Jan 9, 2024
| const cleanPath = request.path.replace(/^\/.netlify\/(functions|builders)/, '') | ||
|
|
||
| functionName = cleanPath.split('/').find(Boolean) | ||
| const match = await functionsRegistry.getFunctionForURLPath( |
There was a problem hiding this comment.
This is the main functional change, all the rest is cleanup.
| const blobsContext = await getBlobsContext({ | ||
| debug: options.debug, | ||
| projectRoot: command.workingDir, | ||
| siteID: site.id ?? 'unknown-site-id', |
There was a problem hiding this comment.
This needs to be updated after #6299.
Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>
eduardoboucas
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
functions:servewasn't able to serve V2 Functions. This PR fixes that, and a couple of other things at the same time.Resolves https://linear.app/netlify/issue/COM-139/ntl-functionsserve-doesnt-support-v2-functions.