-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add flag to skip env var fetching #6723
Conversation
📊 Benchmark resultsComparing with a265859
|
why cannot we use the existing |
We still want to fetch the site config (for the dev command and target port). I could provide that from bitballoon as well in the future (CRE-1431) and then we can use |
As this is public API on the CLI we should provide that probably first to be able to leverage the --offline flag. |
i think there is value in having a flag just for "don't fetch env vars". using |
I'm using |
🎉 Thanks for submitting a pull request! 🎉
Summary
Introduce internal option
--offline-env
to disable using any env vars fetched from the API.This offers better support for the case of receiving all env vars externally (via devbot).
ref CRE-1078
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)