Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dev): update dev server plugin env variable to be an array of pl… #6811

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

VitaliyR
Copy link
Contributor

@VitaliyR VitaliyR commented Sep 9, 2024

…ugins

Summary

Update env var NETLIFY_INCLUDE_DEV_SERVER_PLUGIN to accept array of plugins instead of one.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@VitaliyR VitaliyR requested a review from a team as a code owner September 9, 2024 22:08
{
cwd: builder.directory,
env: {
NETLIFY_INCLUDE_DEV_SERVER_PLUGIN: '@netlify/plugin-1,@netlify/plugin-2',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how are we verifying that @netlify/plugin-2 plugin is also included?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If some plugin is not there, the tests are failing

@VitaliyR VitaliyR merged commit dbcf1f5 into main Sep 10, 2024
48 checks passed
@VitaliyR VitaliyR deleted the update-dev-server-plugins-env branch September 10, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants