fix: process mutated env by plugins in dev server #7045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
davbree
reviewed
Feb 19, 2025
src/utils/run-build.ts
Outdated
| @@ -140,7 +145,7 @@ export const runNetlifyBuild = async ({ | |||
| if (!options.dir && netlifyConfig?.build?.publish) { | |||
| settingsOverrides.dist = netlifyConfig.build.publish | |||
| } | |||
| await devCommand(settingsOverrides) | |||
| await devCommand({ netlifyConfig }) | |||
There was a problem hiding this comment.
what happened to settingsOverrides?
There was a problem hiding this comment.
Thanks, my stash went crazy and not noticed it wasn't added to commit. Fixed
VitaliyR
force-pushed
the
vitaliir/WRFL-2278
branch
from
cd772a2 to
32c3c4b
Compare
eduardoboucas
approved these changes
Feb 20, 2025
VitaliyR
force-pushed
the
vitaliir/WRFL-2278
branch
from
913dd6e to
b50f62e
Compare
VitaliyR
force-pushed
the
vitaliir/WRFL-2278
branch
from
b50f62e to
5b8f1e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes WRFL-2278
Uses netlify/build#6095, until released will fail.
Description in that PR. TL;DR: pass mutated env vars from the build plugins, which can mutate it via tweaking
netlifyConfig.build.environmentobject, to the user site.For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)