feat!: remove deprecated camelCase option variants #7046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These commands option have been deprecated since 12.8.0 (25 months ago): https://github.com/netlify/cli/releases/tag/v12.8.0. Removes: - `--httpProxyCertificateFilename` - `--prodIfUnlocked` - `--functionsPort` - `--targetPort` - `--edgeInspect` - `--edgeInspectBrk` - `--replaceExisting` - `--gitRemoteName` The change in 12.8.0 also intended to rename `--httpProxy` to `--http-proxy` but there was a typo resulting in that never happening. To err on the safe side, this fixes that change without removing the camel case variant yet.
serhalp
force-pushed
the
feat/remove-deprecated-opts
branch
from
1cec941 to
f04e7a2
Compare
📊 Benchmark resultsComparing with b693ba7
|
serhalp
commented
Feb 19, 2025
ndhoule
approved these changes
Feb 19, 2025
This was not a documented option, so this is arguably not breaking, but marking as breaking to err on the side of caution.
and improve the assertion to be less annoying to debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These commands option have been deprecated since 12.8.0 (25 months ago): https://github.com/netlify/cli/releases/tag/v12.8.0.
Removes:
--httpProxyCertificateFilename--prodIfUnlocked--functionsPort--targetPort--edgeInspect--edgeInspectBrk--replaceExisting--gitRemoteNameThe change in 12.8.0 also intended to rename
--httpProxyto--http-proxybut there was a typo resulting in that never happening. While we're cutting a major, this his fixes that by actually renaming it. This was never actually a documented option, so this isn't truly a breaking change.CPLA-2533