-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for Edge Functions debugging #31
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: feature
code contributing to the implementation of a feature and/or user facing functionality
label
May 18, 2022
5 tasks
jackiewmacharia
changed the title
feat: add deno --inspect and --inspect-brk flags
feat: support for Edge Functions debugging
May 18, 2022
@eduardoboucas this one's ready |
eduardoboucas
approved these changes
May 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! It'd be great to start adding some tests for the serving functionality. It's fine to do it in a follow up PR, though. Do you mind opening an issue for it?
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
Apr 23, 2024
* feat: add support for Edge Functions debbugging via deno --inspect and --inspect-brk flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type: feature
code contributing to the implementation of a feature and/or user facing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for sending this pull request! 🎉
Please make sure the title is clear and descriptive.
If you are fixing a typo or documentation, please skip these instructions.
Otherwise please fill in the sections below.
Which problem is this pull request solving?
This PR adds support for Edge Functions debugging
List other issues or pull requests related to this problem
Part of work for https://github.com/netlify/pillar-runtime/issues/357
Instructions on how to test in this CLI PR
Describe the solution you've chosen
Added
--edgeInspect
and--edgeInspectBrk
that can be ran withnetlify dev
as is or with a custom host and port that we then append to the deno flags as either--inspect
and--inspect-brk
in this PRDescribe alternatives you've considered
Example: Another solution would be [...]
Checklist
Please add a
x
inside each checkbox:A picture of a cute animal (not mandatory but encouraged)