feat: allow certificate to be supplied to serve
#7
Conversation
eduardoboucas
added
the
type: feature
I don't see any comments 🤔 |
|
hm, me neither - GitHub swallowed it? 🤷 give me a sec |
| @@ -56,7 +56,9 @@ const prepareServer = ({ | |||
| // no-op | |||
| } | |||
|
|
|||
| await deno.runInBackground(['run', ...flags, stage2Path, port.toString()], true, processRef) | |||
| const bootstrapFlags = ['--port', port.toString()] | |||
There was a problem hiding this comment.
looks like we didn't supply the --port flag before - assuming this is unrelated to the certificate path, was broken before, and you drive-by-fixed this.
There was a problem hiding this comment.
We did supply it, but as a positional parameter and not a flag (i.e. deno run script.js <PORT> as opposed to deno run script.js --port <PORT>). Using flags will allow us to supply additional parameters in the future in a more sustainable way.
You're right that it's not necessarily related to the certificate path, and I should've clarified that. Thanks for calling that out!
There was a problem hiding this comment.
…ge-bundler#7) Co-authored-by: Renovate Bot <bot@renovateapp.com>
* feat: load bootstrap from deploy URL * feat: support loading boot URL from environment variable
…er#7) * feat: allow certificate to be supplied to `serve` * feat: add support for server certificate * refactor: remove `--origin-protocol` flag
Which problem is this pull request solving?
When the
certificatePathoption is supplied to theservemethod, Edge Bundler will calldeno runwith the--certflag.Part of https://github.com/netlify/pillar-runtime/issues/323.