Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for Edge Functions debugging #31

Merged
merged 5 commits into from
May 25, 2022

Conversation

jackiewmacharia
Copy link
Contributor

@jackiewmacharia jackiewmacharia commented May 18, 2022

🎉 Thanks for sending this pull request! 🎉

Please make sure the title is clear and descriptive.

If you are fixing a typo or documentation, please skip these instructions.

Otherwise please fill in the sections below.

Which problem is this pull request solving?
This PR adds support for Edge Functions debugging

List other issues or pull requests related to this problem

Part of work for https://github.com/netlify/pillar-runtime/issues/357
Instructions on how to test in this CLI PR

Describe the solution you've chosen
Added --edgeInspect and --edgeInspectBrk that can be ran with netlify dev as is or with a custom host and port that we then append to the deno flags as either --inspect and --inspect-brk in this PR

Describe alternatives you've considered

Example: Another solution would be [...]

Checklist

Please add a x inside each checkbox:

  • I have read the contribution guidelines.
  • The status checks are successful (continuous integration). Those can be seen below.

A picture of a cute animal (not mandatory but encouraged)
cute animal

@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label May 18, 2022
@jackiewmacharia jackiewmacharia changed the title feat: add deno --inspect and --inspect-brk flags feat: support for Edge Functions debugging May 18, 2022
@jackiewmacharia jackiewmacharia marked this pull request as ready for review May 18, 2022 10:07
@jackiewmacharia jackiewmacharia requested a review from a team May 18, 2022 10:07
src/server/server.ts Outdated Show resolved Hide resolved
@jackiewmacharia
Copy link
Contributor Author

@eduardoboucas this one's ready

src/server/server.ts Outdated Show resolved Hide resolved
Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! It'd be great to start adding some tests for the serving functionality. It's fine to do it in a follow up PR, though. Do you mind opening an issue for it?

@jackiewmacharia jackiewmacharia merged commit d69c79e into main May 25, 2022
Skn0tt pushed a commit to netlify/build that referenced this pull request Apr 23, 2024
* feat: add support for Edge Functions debbugging via deno --inspect and --inspect-brk flags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants