Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Add Remix detection #657

Closed
erezrokah opened this issue Jan 7, 2022 · 1 comment
Closed

Add Remix detection #657

erezrokah opened this issue Jan 7, 2022 · 1 comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality

Comments

@erezrokah
Copy link
Contributor

Which problem is this feature request solving?

Add support for detecting the Remix framework.

Describe the solution you'd like

Add a Remix configuration file to https://github.com/netlify/framework-info/tree/main/src/frameworks

Describe alternatives you've considered

Having users manually configure Remix

Other Context

This will probably be a breaking change for this library, as we'll make dev.port and dev.commands optional:

framework-info/test/frameworks.js

Line 89 in 6641697

required: ['command', 'port', 'pollingStrategies'],

Based on netlify/cli#3654 (comment)
Related to netlify/cli#3655
@erezrokah erezrokah added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Jan 7, 2022
@erezrokah erezrokah mentioned this issue Jan 7, 2022
Closed
@erezrokah
Copy link
Contributor Author

Done in #658

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erezrokah