Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix collection failure if entry fails. #1093

Merged
merged 7 commits into from
Mar 5, 2018
Merged

Fix collection failure if entry fails. #1093

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
563ddd3
Update backend.js
tech4him1 Feb 8, 2018
d3afcc3
Update implementation.js
tech4him1 Feb 8, 2018
919b5e4
Update backend.js
tech4him1 Feb 8, 2018
ca87013
Update implementation.js
tech4him1 Feb 8, 2018
d61e51b
Update backend.js
tech4him1 Feb 9, 2018
501c72c
Update implementation.js
tech4him1 Feb 9, 2018
2b01649
Log console error if file fails to load.
tech4him1 Mar 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/backends/github/implementation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,15 @@ export default class GitHub {
sem.take(() => this.api.readFile(file.path, file.sha).then((data) => {
resolve({ file, data });
sem.leave();
}).catch((err) => {
}).catch((err = true) => {
sem.leave();
reject(err);
console.error(`failed to load file from GitHub: ${file.path}`);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erquhart @Benaiah I added a console error for now, we can add a toast notification or other GUI action later.

resolve({ error: err });
}))
)));
});
return Promise.all(promises);
return Promise.all(promises)
.then(loadedEntries => loadedEntries.filter(loadedEntry => !loadedEntry.error));
};

// Fetches a single entry.
Expand Down