fix: Catch router errors #21
Conversation
|
✔️ Deploy Preview for plugin-angular-universal-demo ready! 🔨 Explore the source changes: 2c9dcde 🔍 Inspect the deploy log: https://app.netlify.com/sites/plugin-angular-universal-demo/deploys/610b100ebaff8e0007c231d8 😎 Browse the preview: https://deploy-preview-21--plugin-angular-universal-demo.netlify.app |
src/helpers/getDynamicTemplates.js
Outdated
| } catch (e) { | ||
| const html = await render(event, context) | ||
| return { | ||
| // todo: how would people change the status code from inside angular code? |
There was a problem hiding this comment.
likely needs a bit of injection...
src/helpers/getDynamicTemplates.js
Outdated
|
|
||
| export * from './src/main.server' | ||
| const html: string = await new Promise((resolve, reject) => { | ||
| // @ts-ignore |
There was a problem hiding this comment.
Adding /// <reference types="zone.js" /> to the top of the file should make this work
| const getAngularBuilder = ({ functionServerPath }) => ` | ||
| const outdent = require('outdent') | ||
| // this is here so this works: https://marketplace.visualstudio.com/items?itemName=zjcompt.es6-string-javascript | ||
| const javascript = outdent |
There was a problem hiding this comment.
Nice trick! I wonder if we should update our eslint rules so we could use an inline comment instead though
There was a problem hiding this comment.
i initially just added outdent because i didn't like the leading spaces in the rendered files. then just aliased it to this name for convience
src/helpers/getDynamicTemplates.js
Outdated
| if (!!query) { | ||
| query = '?' + query; | ||
| } | ||
| return "https://" + event.headers.host + event.path + query; |
There was a problem hiding this comment.
event.headers['x-forwarded-proto'] || 'http'
|
i reverted my changes to the demo site and addressed the comments. |
This adds a zone.js Zone to catch all errors bubbling up from rendering the app module.
In the process i made these refactors:
@nguniversal/express-enginewith@nguniversal/common/enginefor less indirection