feat: merge next-on-netlify into the core plugin repo #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlengstorf
added
the
type: feature
jlengstorf
commented
Mar 5, 2021
jlengstorf
commented
Mar 5, 2021
jlengstorf
commented
Mar 5, 2021
rstavchansky
approved these changes
Mar 5, 2021
There was a problem hiding this comment.
Left some small suggestions.
One thing that's not in the scope of this PR that I noticed:
https://github.com/netlify/netlify-plugin-nextjs/tree/merge-non#custom-netlify-functions
We're still stating that people need to set a Functions directory, but per the new note, they should be able to use the default location if they want.
Co-authored-by: rstavchansky <rachael@netlify.com>
Co-authored-by: rstavchansky <rachael@netlify.com>
jlengstorf
commented
Mar 5, 2021
* fix: 10.0.8 changes loadConfig to be async * wip: make literally everything async bc loadConfig * wip: fix i18n bug, got 10.0.6 tests to pass * wip: NoN tests pass on 10.0.8 but plugin test chdir fixture issue * Fix bug with Jest * fix: delete TO-DO Co-authored-by: ehmicky <ehmicky@gmail.com>
This was referenced Mar 12, 2021
serhalp
pushed a commit
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like a huge PR, but what's happening here is that we're merging the
next-on-netlifyrepo into this build plugin for a few reasons:next-on-netlifyas a standalone package. Everything it does is handled by this plugin with less setup overhead, so moving forward we're making@netlify/plugin-nextjsthe Official Recommendation™ for how to build Next.js sites on NetlifyThe merge of the
next-on-netlifypackage also paves the way for us to make the Next.js development experience on Netlify even more seamless through automatic installs for new Next.js sites. This does not have any effect on existing sites.Because that's a big change in behavior, we're going to treat this as a breaking change despite the fact that there are no actual breaking changes in the code.
Check out the updates to the changelog for more information on how this affects existing sites (tl;dr it doesn't unless you want it to) and how things will work with new sites going forward.
We're super excited about this change, and we hope you will be, too!