Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the protocol field configurable in conntrack #501

Open
ronensc opened this issue Sep 20, 2023 · 2 comments
Open

Make the protocol field configurable in conntrack #501

ronensc opened this issue Sep 20, 2023 · 2 comments

Comments

@ronensc
Copy link
Collaborator

ronensc commented Sep 20, 2023

Currently, the conntrack module looks for the protocol in the field Proto to filter out non-transport flowlogs.

This breaks make ocp-deploy in a way that connections aren't being tracked. The reason is that Proto is missing (because it was renamed to proto) so all flowlogs are filtered out.

- input: Proto
output: proto

I suggest to add ProtocolFieldName setting to the conntrack configuration to allow specifying a custom field name for the protocol field other than Proto. If this setting is not set, Proto could be set as a default for backward compatibility.

@jotak
Copy link
Member

jotak commented Sep 21, 2023

sounds good to me
Looks like there's also the "Duplicate" field being hardcoded the same way, in generic_map.go

@ronensc
Copy link
Collaborator Author

ronensc commented Sep 26, 2023

Correct. Thanks for bringing this up. I forgot to mention this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants