Skip to content

depth limit of 400 when parsing JSON ! Why? #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mamtananavati opened this issue Mar 15, 2023 · 9 comments
Closed

depth limit of 400 when parsing JSON ! Why? #131

mamtananavati opened this issue Mar 15, 2023 · 9 comments
Labels

Comments

@mamtananavati
Copy link

Why was the depth limit set to 400 and is there a way to override this?

@hezhangjian
Copy link
Collaborator

Thanks for your reply, let me take a look this weekend

@ewoelfel
Copy link
Contributor

ewoelfel commented Mar 17, 2023

I guess the limitation was done due to this CVE the error was found under Jfrog.

So it seems to be necessary, however a patch version upgrade would not be sufficient for this breaking change imho.

This is also related to the issue #132

@hezhangjian
Copy link
Collaborator

I think #133 can close this issue. Feel free to reopen it.

@ColdFireIce
Copy link

As I agree, that 400 should be enough depth, the argument still stands.
Shouldn't there be an option to override this default value?

@hezhangjian hezhangjian reopened this Mar 17, 2023
@hezhangjian
Copy link
Collaborator

@ColdFireIce I think it was hard coded to fix security problems. It's reasonable for users to override this default value

@hezhangjian
Copy link
Collaborator

hezhangjian commented Mar 17, 2023

@ColdFireIce Since depth 400 is enough for mostly scenario. And now we only have one int param(premissive). I believe it can be scheduled in future version.

@UrielCh
Copy link
Contributor

UrielCh commented Mar 17, 2023

V2.4.10 is released.

wait for confirmation before closing the issue.

@UrielCh UrielCh added the Fixed label Mar 17, 2023
@ColdFireIce
Copy link

Thank you for the release. But this issue does not relate to the Problem in #132.
This issue here asks for a feature in the future to override the default value for the call-depth.

@UrielCh
Copy link
Contributor

UrielCh commented Mar 17, 2023

Okay, please provide me a case where anyone needs more than 400 call-depth.

If you find one we can add an argument to customize this limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants