Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSGi support #2

Closed
aborg0 opened this issue Sep 21, 2014 · 6 comments
Closed

OSGi support #2

aborg0 opened this issue Sep 21, 2014 · 6 comments

Comments

@aborg0
Copy link

aborg0 commented Sep 21, 2014

It would be nice to have OSGi-compatible MANIFEST.MF included (also in its asm dependency) in the generated artifacts.

@UrielCh
Copy link
Contributor

UrielCh commented Sep 22, 2014

I don’t know how to patch my pom.xml to generate MANIFEST.MF files, or simply add a MANIFEST.MF in the src/resources directory.
On this point I would appreciate some help.

@aborg0
Copy link
Author

aborg0 commented Sep 22, 2014

Thanks for looking after it. Probably this patch might give an idea, or this one both uses the maven-bundle-plugin, so this seems to be pretty standard, although there might be other alternatives.

aborg0 added a commit to aborg0/json-smart-v2 that referenced this issue Sep 23, 2014
@UrielCh
Copy link
Contributor

UrielCh commented Oct 19, 2014

2.1.0 is released on maven central repo

@UrielCh UrielCh closed this as completed Oct 19, 2014
@aborg0
Copy link
Author

aborg0 commented Oct 19, 2014

Thanks for the fast release. Though I am afraid it contains incompatible changes regarding the semantic versioning (the current classes in the mapper package should be just deprecated before the release of 3.0, where you could release it as removed).

@UrielCh
Copy link
Contributor

UrielCh commented Oct 19, 2014

As I never release any documentation about mapping package, I was Thinking
that nobody directely use It.

That why I do no deprecated this package First.

2014-10-19 23:33 GMT+02:00 Gábor Bakos notifications@github.com:

Thanks for the fast release. Though I am afraid it contains incompatible
changes regarding the semantic versioning http://semver.org/ (the
current classes in the mapper package should be just deprecated before the
release of 3.0, where you could release it as removed).


Reply to this email directly or view it on GitHub
#2 (comment).

@aborg0
Copy link
Author

aborg0 commented Oct 19, 2014

I think it is used by JsonPath here. (Though probably it should declare json-smart as an optional dependency.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants