Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 6074ad2

Browse files
committedMay 21, 2015
UIMacros: Latte 2.4 generates short array syntax
1 parent 9a793cb commit 6074ad2

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed
 

‎composer.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"nette/di": "~2.3",
3131
"nette/forms": "~2.2",
3232
"nette/robot-loader": "~2.2",
33-
"latte/latte": "~2.3"
33+
"latte/latte": "~2.4"
3434
},
3535
"conflict": {
3636
"nette/nette": "<2.2"

‎src/Bridges/ApplicationLatte/UIMacros.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public function macroControl(MacroNode $node, PhpWriter $writer)
7373
$method = Strings::match($method, '#^\w*\z#') ? "render$method" : "{\"render$method\"}";
7474
$param = $writer->formatArray();
7575
if (!Strings::contains($node->args, '=>')) {
76-
$param = substr($param, 6, -1); // removes array()
76+
$param = substr($param, $param[0] === '[' ? 1 : 6, -1); // removes array() or []
7777
}
7878
return ($name[0] === '$' ? "if (is_object($name)) \$_l->tmp = $name; else " : '')
7979
. '$_l->tmp = $_control->getComponent(' . $name . '); '

‎tests/Application.Latte/UIMacros.control.phpt

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,6 @@ Assert::match( '<?php if (is_object($form)) %a% else %a% $_control->getComponent
2121
Assert::match( '<?php %a% $_control->getComponent("form"); %a%->renderType() ?>', $compiler->expandMacro('control', 'form:type', '')->openingCode );
2222
Assert::match( '<?php %a% $_control->getComponent("form"); %a%->{"render$type"}() ?>', $compiler->expandMacro('control', 'form:$type', '')->openingCode );
2323
Assert::match( '<?php %a% $_control->getComponent("form"); %a%->renderType(\'param\') ?>', $compiler->expandMacro('control', 'form:type param', '')->openingCode );
24-
Assert::match( '<?php %a% $_control->getComponent("form"); %a%->renderType(array(\'param\' => 123)) ?>', $compiler->expandMacro('control', 'form:type param => 123', '')->openingCode );
25-
Assert::match( '<?php %a% $_control->getComponent("form"); %a%->renderType(array(\'param\' => 123)) ?>', $compiler->expandMacro('control', 'form:type, param => 123', '')->openingCode );
24+
Assert::match( '<?php %a% $_control->getComponent("form"); %a%->renderType([\'param\' => 123]) ?>', $compiler->expandMacro('control', 'form:type param => 123', '')->openingCode );
25+
Assert::match( '<?php %a% $_control->getComponent("form"); %a%->renderType([\'param\' => 123]) ?>', $compiler->expandMacro('control', 'form:type, param => 123', '')->openingCode );
2626
Assert::match( '<?php %a% $_control->getComponent("form"); %a%->render(); echo $template->striptags(%a%) ?>', $compiler->expandMacro('control', 'form', 'striptags')->openingCode );

‎tests/Application.Latte/UIMacros.link.phpt

+3-3
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,6 @@ Assert::same( '<?php echo $_control->link("$p:$a") ?>', $compiler->expandMacro(
2525
Assert::same( '<?php echo $_control->link("p:a") ?>', $compiler->expandMacro('link', '"p:a"', '')->openingCode );
2626
Assert::same( '<?php echo $_control->link(\'p:a\') ?>', $compiler->expandMacro('link', "'p:a'", '')->openingCode );
2727

28-
Assert::same( '<?php echo $_control->link("p", array(\'param\')) ?>', $compiler->expandMacro('link', 'p param', '')->openingCode );
29-
Assert::same( '<?php echo $_control->link("p", array(\'param\' => 123)) ?>', $compiler->expandMacro('link', 'p param => 123', '')->openingCode );
30-
Assert::same( '<?php echo $_control->link("p", array(\'param\' => 123)) ?>', $compiler->expandMacro('link', 'p, param => 123', '')->openingCode );
28+
Assert::same( '<?php echo $_control->link("p", [\'param\']) ?>', $compiler->expandMacro('link', 'p param', '')->openingCode );
29+
Assert::same( '<?php echo $_control->link("p", [\'param\' => 123]) ?>', $compiler->expandMacro('link', 'p param => 123', '')->openingCode );
30+
Assert::same( '<?php echo $_control->link("p", [\'param\' => 123]) ?>', $compiler->expandMacro('link', 'p, param => 123', '')->openingCode );

0 commit comments

Comments
 (0)
Please sign in to comment.