Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider implementing a custom stream map #54

Open
normanmaurer opened this issue Nov 23, 2020 · 3 comments
Open

Consider implementing a custom stream map #54

normanmaurer opened this issue Nov 23, 2020 · 3 comments

Comments

@normanmaurer
Copy link
Member

See apple/swift-nio-http2#258

@Bue-von-hon
Copy link

I will participate. 💪

@tsegismont
Copy link

Hi @Bue-von-hon , I talked about this with @franz1981 and was planning to start working on it in a few weeks. But if you have some time now, that's great.

Here are a couple things we discussed and that might be of interest.

Unlike swift-nio-http2, Netty already uses a "specialized" data structure to store stream state, IntObjectHashMap. So the possible performance gains, if any, may not be as important as described in apple/swift-nio-http2#258.

The plan was to benchmark (probably using techempower plaintext scenario adapted to HTTP/2) and see whether the cost of IntObjectHashMap pops up.

Regarding possible implementations, @franz1981 pointed to his ArrayRingBuffer experiment as a starting point.

@Bue-von-hon
Copy link

I have submitted a PR #768 PTAL 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants