Forbidding non uppercase statics causes build to fail

[mattyhall]

With rustc version 0.12.0-nightly (136ab3c6b 2014-10-04 00:17:04 +0000) rust-xml will no longer build. It gives this error:

<std macros>:12:21: 12:42 error: allow(non_uppercase_statics) overruled by outer forbid(non_uppercase_statics)
<std macros>:12             #[allow(non_uppercase_statics)]
                                    ^~~~~~~~~~~~~~~~~~~~~
<std macros>:1:1: 138:2 note: in expansion of bitflags!
src/writer/emitter.rs:111:1: 117:2 note: expansion site
<std macros>:12:21: 12:42 error: allow(non_uppercase_statics) overruled by outer forbid(non_uppercase_statics)
<std macros>:12             #[allow(non_uppercase_statics)]
                                    ^~~~~~~~~~~~~~~~~~~~~
<std macros>:1:1: 138:2 note: in expansion of bitflags!
src/writer/emitter.rs:111:1: 117:2 note: expansion site
<std macros>:12:21: 12:42 error: allow(non_uppercase_statics) overruled by outer forbid(non_uppercase_statics)
<std macros>:12             #[allow(non_uppercase_statics)]

It appears that the ![forbid(non_uppercase_statics)] in src/lib.rs conflicts with a #[allow(non_uppercase_statics)] in the bitflags! macro. Removing the forbid from src/lib.rs fixes it but I don't know if that's something you actually want to do.

[netvl]

This is really strange. It looks like an issue in Rust compiler or std library. As far as I understand, this means that #[forbid(non_uppercase_statics)] is useless if bitflags! macro (or another similar one) is used somewhere in the code.

I guess it's ok to remove the forbid as a temporary measure. Feel free to submit your commit as a PR :)

[mattyhall]

Weird! I'll submit the PR. Just a quick fix whilst the bug is fixed in rust hopefully!

[jakerr]

FYI: This was fixed in rustc if you'd like to put the forbid back in.