Skip to content

fix for un-feature-gated struct variants #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2014
Merged

fix for un-feature-gated struct variants #27

merged 1 commit into from
Nov 17, 2014

Conversation

HeroesGrave
Copy link
Contributor

No description provided.

@netvl
Copy link
Owner

netvl commented Nov 17, 2014

Great, thanks!
I'm hesitant to merge right now, however. I've just updated to the latest nightlies and this change is not there yet. Travis CI seems to agree with me.
@bjz, @tomaka, what do you think? Won't it break anything?

@tomaka
Copy link
Collaborator

tomaka commented Nov 17, 2014

I think that most people use the nightlies instead of compiling rust master.

We have a similar PR in gl-rs right now where I said that we'd wait for the nightlies to be published.
It's usually between 7:00 and 10:00 UTC, except when there's a problem and no nightly is published at all..

@netvl
Copy link
Owner

netvl commented Nov 17, 2014

Ok, let's wait then.
There is something strange happening on nightly buildbot, however: linux, win32, win64, mac
It looks like that today builds went fine on linux and windows, but mac builds lag behind for several days. And versions on static.rust-lang seems to be even older...

@tomaka
Copy link
Collaborator

tomaka commented Nov 17, 2014

The nightlies are released, I restarted the travis build.

tomaka added a commit that referenced this pull request Nov 17, 2014
fix for un-feature-gated struct variants
@tomaka tomaka merged commit a17c2b5 into netvl:master Nov 17, 2014
@netvl
Copy link
Owner

netvl commented Nov 17, 2014

Thanks!

@ghost ghost mentioned this pull request Nov 17, 2014
@gchp
Copy link

gchp commented Nov 17, 2014

This is causing errors for me on OSX, just updated via the rustup script. Should I get the nightlies some other way?

@netvl
Copy link
Owner

netvl commented Nov 17, 2014

@gchp, it looks like buildbot for mac is stopped for some reason. It isn't building nightlies for two days already, so there are simply no fresh nightlies available for Mac. I've submitted an issue here, hopefully it is fixed soon. In the meantime, I'm afraid, you will have to compile Rust itself, or freeze rust-xml/gl-rs/other affected libraries versions by cloning their repositories, selecting appropriate commit and hardcoding their paths to ~/.cargo/config (or maybe some easier methods to select libraries revision are now available in Cargo, I don't know).

@gchp
Copy link

gchp commented Nov 18, 2014

@netvl cool, thanks for the response! Built rust myself and it works fine.

@netvl
Copy link
Owner

netvl commented Nov 18, 2014

@gchp, btw, mac buildbot seems to be fixed, and mac nightlies seems to be fresh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants