Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Seperate functions into modules? #21

Closed
hasezoey opened this issue Mar 29, 2022 · 2 comments
Closed

[Discussion] Seperate functions into modules? #21

hasezoey opened this issue Mar 29, 2022 · 2 comments

Comments

@hasezoey
Copy link

Currently there is only a big lib.rs file which houses all the content of the library, which is kinda bad when wanting to extend it (for example #18), so i wanted to open a discussion and get some feedback before making a PR

Note: this issue is made, because the "Discussions" feature is not yet enabled for this repository

@ijackson
Copy link

ijackson commented Aug 3, 2022

Hi. As discussed in #17 I am taking over maintenance of this crate. The new repository is here: https://gitlab.com/ijackson/rust-shellexpand

I agree that the single giant lib.rs might be worth splitting up. I have filed https://gitlab.com/ijackson/rust-shellexpand/-/issues/3 about this,

@hasezoey
Copy link
Author

hasezoey commented Aug 3, 2022

@hasezoey hasezoey closed this as completed Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants