Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code initial cmd-admission-webhook-k8s #1

Closed
edwarnicke opened this issue Mar 8, 2021 · 0 comments · Fixed by #2
Closed

Code initial cmd-admission-webhook-k8s #1

edwarnicke opened this issue Mar 8, 2021 · 0 comments · Fixed by #2
Assignees
Labels
enhancement New feature or request

Comments

@edwarnicke
Copy link
Member

Write an admissions webhook similar to https://github.com/networkservicemesh/networkservicemesh/tree/master/k8s/cmd/admission-webhook

Please do not bring across the "github.com/networkservicemesh/networkservicemesh/*" dependencies. Many of them do not need to be replicated (like probes). Keep things simple :)

@Bolodya1997 do we need to update the NSM URL schema compared to https://github.com/networkservicemesh/networkservicemesh/blob/756a5e48592b29174765657cf3a4cb79c3491240/pkg/tools/tools.go#L195 ? Do we have a lib in sdk for that currently? I recall you did some smart things for sriov in terms of updating the URL.. but don't remember them precisely. Pointers welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants